search

isaacs / sax-js

A sax style parser for JS
Other
1.09k stars 325 forks source link

Change this to window for cleaner bundling #225

Closed alex-r-bigelow closed 6 years ago

alex-r-bigelow commented 6 years ago

Not sure how to create a test for this in the existing framework, but I can confirm that Rollup does the right thing with this change

Fixes #224

alex-r-bigelow commented 6 years ago

... and fiddling with my settings this morning, all of a sudden Rollup is behaving, even with the original version. So disregard this PR.