search

isaacs / sax-js

A sax style parser for JS
Other
1.09k stars 325 forks source link

Update standard #227

Closed michaelnisi closed 5 years ago

michaelnisi commented 6 years ago

Forgot to npm install before testing. Posttests standard check failed with new Buffer() warnings, using my local global standard@10.0.3. I was about to fix the Buffer syntax, but updating standard to ^11.0.0 resolved the issue. Not sure why though.

michaelnisi commented 6 years ago

Oh, wait! It fails for Node.js 4 and 6. There are no miracles after all. Hang on.

michaelnisi commented 6 years ago

Introducing safe-buffer as development dependency may be fine.

michaelnisi commented 6 years ago

Alright, as Travis uses >4.5.0 for Node.js 4, just adjusting the tests, not introducing a new dependency, is fine. I squash the PR if you like.