search

isaacs / tshy

Other
890 stars 18 forks source link

Respect package.json type #47

Closed starnayuta closed 8 months ago

starnayuta commented 8 months ago

If type is set to commonjs in package.json, this should be respected.
Currently, type is always changed to module.

For example, during the migration of the commonjs library, we want the project type to be commonjs.

boneskull commented 8 months ago

I'm curious about the use-case for this. If you don't intend to ship ESM, why use tshy?

isaacs commented 8 months ago

@boneskull Well, it could be that your tests and scripts are all written in commonjs, or something like that, so it's easier to just have the package.json default to that.

isaacs commented 8 months ago

Fixed on 1.12