search

isaacsanders / omniauth-stripe-connect

Stripe Connect OAuth2 Strategy for OmniAuth 1.0
MIT License
130 stars 74 forks source link

upgrade from 2.9.0 to 2.10.0 leads to `invalid_redirect_uri` error #48

Closed srt32 closed 6 years ago

srt32 commented 6 years ago

We recently upgraded from 2.9.0 to 2.10.0. Upon upgrading we experienced the below invalid_redirect_uri error that we did not see before the upgrade.

This version bump seems to only bump transitive dependencies. Is there any updated config needed to make the new version work properly?

{
  "error": "invalid_redirect_uri",
  "error_description": "Invalid redirect URI 'https://mydomain.com/callback'. Ensure this uri exactly matches one of the uris specified in your application settings",
  "state": "state-field-foo"
}

Thanks!

ryanclark2 commented 6 years ago

We did some research and found that overriding the callback_url url in our strategy in our initializer and excluding the query_string made this work. It would be nice not to have to do that.

Related issue: https://github.com/intridea/omniauth-oauth2/issues/93#issuecomment-257319242

🌞

isaacsanders commented 6 years ago

@srt32 @ryanclark2 @chrt00 PR #47 has the relevant method, but it is buried under adding the use of a JWT to the gem.

I would be happy to merge a PR with just the callback_url method defined.

ryanclark2 commented 6 years ago

@isaacsanders Yup, that's exactly what we did. If you'd like a PR with just that in it, let me know.

isaacsanders commented 6 years ago

I'm into it.

isaacsanders commented 6 years ago

As in, yes, I would like a PR, and will merge it in/cut a release.

ryanclark2 commented 6 years ago

Ha, I caught your drift. I'll send it over it a short bit. Thanks.

isaacsanders commented 6 years ago

Version 2.10.1 released

isaacsanders commented 6 years ago

@srt32 @ryanclark2 If either of you two are still working on this, I would appreciate it if you would confirm that 2.10.1 fixes the issue for you.