Overwrite callback_url so that it doesn't include query params since Stripe doesn't support them

isaacsanders / omniauth-stripe-connect

Stripe Connect OAuth2 Strategy for OmniAuth 1.0

MIT License

130 stars 74 forks source link

Overwrite callback_url so that it doesn't include query params since Stripe doesn't support them #49

Closed ryanclark2 closed 6 years ago

ryanclark2 commented 6 years ago

Addresses: https://github.com/isaacsanders/omniauth-stripe-connect/issues/48

isaacsanders commented 6 years ago

@ryanclark2 Can you force push and remove the addition of the .idea workspace? After that, let me know, and I would be happy to merge and release a new change.

ryanclark2 commented 6 years ago

@isaacsanders Done! Thought I'd killed all of that stuff.

langalex commented 6 years ago

also just stumbled across this problem (#48). can this PR be merged and released?

isaacsanders commented 6 years ago

@langalex thanks for the ping. I will merge and release later this morning.

sunsheeppoplar commented 6 years ago

Hiya. Thanks for the support with the maintenance of this gem! Was there a reason this was never merged?

isaacsanders commented 6 years ago

I likely got distracted. I haven’t worked with this for my day job in 6 years, so I don’t have a lot of time to spend on it.

swrobel commented 6 years ago

@isaacsanders I'm happy to take over maintenance of this gem. Just let me know if you're interested & we can discuss.

swrobel commented 6 years ago

@isaacsanders ping!

isaacsanders commented 6 years ago

@swrobel I appreciate the ping. Sorry to have not responded to your previous message. Feel free to email me if you are still interested, we can chat.