isaacsanders / omniauth-stripe-connect

Stripe Connect OAuth2 Strategy for OmniAuth 1.0
MIT License
130 stars 74 forks source link

multiple stripe account #50

Closed seb-sykio closed 6 years ago

seb-sykio commented 6 years ago

hi,

on our plateform, we deal with multiple stripe account. we also use devise.

I saw : config.omniauth :stripe_connect, "STRIPE_CONNECT_CLIENT_ID", "STRIPE_SECRET"

Is it possible to set the "STRIPE_CONNECT_CLIENT_ID" and "STRIPE_SECRET" dynamically for each request ?

thanks

isaacsanders commented 6 years ago

This seems like the wrong way to use this feature. I might be wrong.

phstc commented 6 years ago

@isaacsanders I have a similar need. For my test users User#mode=test, I would like to connect them to my Stripe test account, which has a different set of keys.

image

These "test users" are literally for testing purposes, and using a test account/mode allows me to place orders with fake credit cards 4111 1111 1111 1111.

isaacsanders commented 6 years ago

@seb-sykio @phstc

I will consider this feature if:

I am not going to work on this feature, because I think it is a code smell, and I have other things I would rather do. But if this is important enough to either of you two, then I will consider the pull request.

phstc commented 6 years ago

Hi @isaacsanders

I wouldn't call it a code smell, since it is a valid business need.

Anyway, I don't really think this is a responsibility of omniauth-stripe-connect, this should be something in omniauth directly. Which is supposed to be supported already:

I tried a few options, but I couldn't make them work with omniauth-stripe-connect yet, maybe there's something that needs to be updated on this strategy, I will play more with it, and create a pull request in case it makes sense.

Thanks checking back this issue and of course for omniauth-stripe-connect 👏

isaacsanders commented 6 years ago

@phstc I look forward to your pull request.

Just to clarify, are you interested in a different configuration on each request, or a different configuration as per the deploy environment? The original issue was for something different than the examples you provided, if I'm reading it right.