search

isaacsanders / omniauth-stripe-connect

Stripe Connect OAuth2 Strategy for OmniAuth 1.0
MIT License
130 stars 74 forks source link

Updates README with config info for Devise models to produce callback routes #51

Closed sunsheeppoplar closed 6 years ago

sunsheeppoplar commented 6 years ago

Thanks again for the gem in the first place - it's been very helpful today!

swrobel commented 6 years ago

Hm, I haven't needed to add the config to user.rb to get it to work in my app... Any idea why you had to?

sunsheeppoplar commented 6 years ago

Not totally sure. I was under the impression that it's standard way of devise and omniauth solutions to talk to each other in regards to routing. What version of devise are you running? I could reproduce a repo for you?

Cf. https://github.com/plataformatec/devise/wiki/OmniAuth:-Overview

isaacsanders commented 6 years ago

@sunsheeppoplar @swrobel Have you two reached a consensus on this topic?

swrobel commented 6 years ago

@sunsheeppoplar I'm on Devise 4.4.3, Omniauth 1.8.1, Omniauth-OAuth2 1.5.0

sunsheeppoplar commented 6 years ago

@swrobel What version of Rails?

swrobel commented 6 years ago

5.2.0.rc2

isaacsanders commented 6 years ago

So is the consensus on this Documentation that it is valid?

swrobel commented 6 years ago

@isaacsanders @sunsheeppoplar it's probably Devise best-practice, so it seems fine to me. I only have :omniauthable, omniauth_providers: [:facebook] but then again, I don't actually sign users in with Stripe, just use the oauth flow to get tokens.