isaacsanders / omniauth-stripe-connect

Stripe Connect OAuth2 Strategy for OmniAuth 1.0
MIT License
130 stars 74 forks source link

Oauth dependences upate v2 #64

Closed simonx1 closed 2 years ago

simonx1 commented 2 years ago

There is a dependency that may be updated.

isaacsanders commented 2 years ago

@simonx1 Can you show me an example of why we'd want to remove the _method param?

dgpokl commented 2 years ago

Unless you can demonstrate the need for the request params, I will have to reject this. I would accept a PR for just the omniauth dependency update.

Not PR author, but I think this is the reasoning:

Again I can't personally guarantee that dropping that param here is definitely needed as I'm not an expert on this library or omniauth, however I think that's at least the rationale.

isaacsanders commented 2 years ago

@dgpokl works for me