Closed timrogers closed 9 years ago
I think it shouldn't matter - we should recommend using rails time methods on Fixnum (ie. 5.seconds
, etc), which makes it unambiguous. What do you think]
That's what I'm doing in my implementation and is what most people probably will want!
Perhaps state that it's number of seconds, and use the Rails Fixnum methods in the examples? (Probably with a clarifying comment.)
Sent from my iPhone
On 27 Jun 2015, at 16:20, Isaac Seymour notifications@github.com wrote:
I think it shouldn't matter - we should recommend using rails time methods on Fixnum (ie. 5.seconds, etc), which makes it unambiguous. What do you think]
— Reply to this email directly or view it on GitHub.
Yeah, my only worry with this is that by saying it's in seconds it won't be clear that that can be produced using 5.seconds
etc (I didn't know that all those methods just returned a number of seconds!) Using the ActiveSupport methods in the examples clears that up though I think :+1:
@isaacseymour Done! Happy to merge?
:+1: :+1: :+1:
It's not too clear in the readme at the moment that delay times are in seconds.
Am I right that they are? Looks like that's the case from http://api.rubyonrails.org/classes/ActiveJob/Enqueuing.html