search

isaacseymour / activejob-retry

Automatic retries for ActiveJob
MIT License
138 stars 14 forks source link

As of version `3.1.0` QC supports `enqueue_at` #34

Closed senny closed 8 years ago

senny commented 8 years ago

The latest version of queue_classic does support enqueue_at.

See https://github.com/QueueClassic/queue_classic/pull/217

For QC users with versions older than 3.1.0 this patch could lead to harder to debug problems. I still feel that it's the responsibility of Active Job to bark when something isn't supported.

isaacseymour commented 8 years ago

Sweet. I don't think it would be too hard to check if the QueueClassic version is < 3.1.0 and raise in that case, so would really like to have that in before merging this PR.

senny commented 8 years ago

I don't think this library should have to go into so much depth to figure out the working conditions. In the end, don't you just rely on enqueue_at? Why not assume that every adapter is working and then have them raise when enqueue_at is called but they don't support it. Active Job should have appropriate messages in these cases.

isaacseymour commented 8 years ago

Actually, rereading the way this constant is used we can only warn when you're using a problematic adapter, since you're almost certainly using one in tests. Guess we can't be that helpful after all. :+1: thanks for the heads up @senny !

senny commented 8 years ago

thank you :yellow_heart:

isaacseymour commented 8 years ago

Published to RubyGems in v0.5.1. Thanks again for the contrib!