search

isaacseymour / activejob-retry

Automatic retries for ActiveJob
MIT License
138 stars 14 forks source link

Remove pry #7

Closed greysteil closed 9 years ago

greysteil commented 9 years ago

Probably don't want it by default, no?

greysteil commented 9 years ago

@isaacseymour - I've also set up travis to track, so we'll get a build report for this PR.

isaacseymour commented 9 years ago

This means you have to explicitly require 'pry' whenever you want to use binding.pry which is a bit of a pain :/

greysteil commented 9 years ago

Yep, but not sure the gem should be opinionated on how to do debugging. Up to you!

isaacseymour commented 9 years ago

True!

greysteil commented 9 years ago

Failure is unrelated. Should be fixed by https://github.com/gocardless/activejob-retry/pull/8

greysteil commented 9 years ago

Also, we'll need to special case on the Ruby version if you want to keep this in. See https://travis-ci.org/gocardless/activejob-retry/jobs/45612172

isaacseymour commented 9 years ago

Ugh, definitely not worth it. Let's merge.