search

isaakhanimann / psychonautwiki-journal-android

GNU General Public License v3.0
64 stars 12 forks source link

some minor search improvements (Attempt #2) #21

Closed jaromeyer closed 1 year ago

jaromeyer commented 1 year ago

I already managed to push everything to main... so here we go again:

First of all, thank you for this! I started working on a very similar app in Flutter but found yours just in time.

Now to the PR: The changes allow a person to search for e.g. '2cb' or '5meo mipt'.

I also combine SearchScreenWithoutDrawerButton and SearchScreenWithDrawerButton because they share almost the same code. Should category filters be hidden when SearchScreen is used to add a new ingestion?

Unrelated to this PR: what is your opinion on Navigation bars? They seem to be the preferred solution from what I have read. At least to me the current side bar (and navigation in general) feels pretty clunky when using gesture navigation.

isaakhanimann commented 1 year ago

I'll try to get a look at it the coming weekend. I started separating the SearchScreenWithoutDrawerButton and SearchScreenWithDrawerButton because they should soon look differently anyway. It would be nice to have one search field that filters the quick logging suggestions and substances at once, similar to the iOS version.

I think Navigation bars is an option worth investigating. It was there before but I removed it so there was more space to focus and because I don't know how to hide it without having an ugly animation when navigating to different screens.