search

isaakhanimann / psychonautwiki-journal-android

GNU General Public License v3.0
50 stars 10 forks source link

Updating substances.json #29

Closed Im-0xea closed 8 months ago

Im-0xea commented 8 months ago

Hyia!

I have been playing around a bit with your wonderful app! and I would be interested in updating the substances dataset (ie "substances.json").

sorry if I missed any build options, scripts, etc, im very very new to gradle and after looking around a bit, I failed to find anything.

lots of love, Xea

isaakhanimann commented 8 months ago

The way to update it is to update the data in PsychonautWiki and then the changes will automatically be in the next release.

Im-0xea commented 8 months ago

@isaakhanimann

well, im already building it from source, which is working fine for me, I have already done some small fixes and would not like to wait till the next release to fix some substances, seams somehow the content of substances.json got updated now.

anyhow thanks for your timely reply!

isaakhanimann commented 8 months ago

I don’t understand what you are suggesting. The substances.json is created in a separate repo: https://github.com/isaakhanimann/substance-scraping In that repo it basically fetches the data of the PsychonautWiki API and then transforms it a bit. But the important thing to note is that as much as possible PsychonautWiki is the source of truth through the API.

isaakhanimann commented 8 months ago

If you are doing small fixes on the substances do the small fixes on PsychonautWiki, not the substances.json. Its impossible to update this data for users without a new release because this data is not fetched from a network but shipped in the app so its always available offline.

Im-0xea commented 8 months ago

I don’t understand what you are suggesting. The substances.json is created in a separate repo: https://github.com/isaakhanimann/substance-scraping In that repo it basically fetches the data of the PsychonautWiki API and then transforms it a bit. But the important thing to note is that as much as possible PsychonautWiki is the source of truth through the API.

that is everything I needed to know!, thank you very much!

and thank you again for your amazing work, I use your app every day and it has been quite helpful

isaakhanimann commented 8 months ago

I appreciate it. Thank you 😊