search

isaakhanimann / psychonautwiki-journal-android

GNU General Public License v3.0
64 stars 12 forks source link

UI cleanup & bugfixes #35

Closed jaromeyer closed 8 months ago

jaromeyer commented 8 months ago

Mostly some UI tweaks I've been using myself. Jumping between substance and statistics currently results in a weird navigation stack state where the wrong navbar item is highlighted, however it is still usable as-is. Feel free to cherry-pick whatever you find useful.

isaakhanimann commented 8 months ago

Hey, thank you very much for your contribution! I cherry-picked all changes except the navigation across tabs and some of the tab bar names. Navigating from one tab to another from within a tab is unexpected and the way navigation is implemented it doesn't accommodate for that. Renaming Search to Substances would be nice but doesn't fit into the tab bar anymore without text wrapping, same for Safer -> Safer Use and Stats -> Statistics.

I have some other changes that I will add to the release soon so it might take a bit of time until I will make a new release.

isaakhanimann commented 8 months ago

What a coincidence that you live in Zurich and study CS. Me too! I graduated a year ago.

jaromeyer commented 8 months ago

@isaakhanimann My main motivation was adjusting the navbar names to match the title shown on the tab itself, didn't think about wrapping since it looked fine on my phone ooops.

What would be the correct way of implementing the navigation? Should I add SubstanceCompanion to the stats navigation graph and vice versa so they can be opened in the same tab?

jaromeyer commented 8 months ago

What a coincidence that you live in Zurich and study CS. Me too! I graduated a year ago.

what a coincidence indeed! did you do the consecutive CS master at ETH?