search

isaakhanimann / psychonautwiki-journal-android

GNU General Public License v3.0
50 stars 10 forks source link

Feature Request: Have the graph show different substances relative to their dose intensity #49

Open smiba opened 1 month ago

smiba commented 1 month ago

Right now when combining substances, the graph doesn't take their dose intensity into consideration.

if you take 50g of alcohol, and 1mg of caffeine, this peaks at the exact same height in the graph even though the caffeine is negligible.

Screenshot_20240510_120602_Journal

It would make more sense for the y-axis of the graph to be made in reference to the strength of the dose at that point. We already know what dosages are light/moderate/heavy etc, why not graph according to this?

isaakhanimann commented 1 month ago

Because its difficult to compare strength of different substances. Compare a common dose of Caffeine with a common dose of LSD. So better to not compare them at all. Also you can't really make an absolute y scale because some people e.g. take 5x the heavy dose. Also I don't want this gameification where people try to reach the top of the timeline. So I think the sensible thing is to just have the right relative to other ingestions of the same substance in the same experience.

smiba commented 1 month ago

@isaakhanimann

Not sure if I entirely agree, the y-axis would simply be 0 - [highest dosage of current session]. This doesn't cause any gamification, it simply makes the graph readable. There is no top of the timeline, the top is always an already reached point with what was already been ingested.

If someone were to take 5x the heavy dose, the y-axis would max out at 5 times the heavy dose. If someone only took a moderate dose at best, the axis maxes out at the moderate dose.

Take for example the Journal I had yesterday:

Screenshot_20240510_133648_Journal

This to me would look like the Orange colour (which I picked for Caffeine) is going to take up the majority of my experience, however the caffeine is relatively low (it's in the cola I was drinking) so it should've been much lower on the scale.
The graph as in that moment is really confusing and imo pretty useless.

Would love for you to reconsider, I think it would not take up too much time to implement either.

isaakhanimann commented 1 month ago

I think I get what you mean now. Doses are always converted to a kind of strength scale and then the heights can be compared across substances. But the strongest dose still takes the full height no matter how light it is.

I think its a good idea. Just have to handle unknown doses or unknown strength of dose gracefully.

Please create a PR with the changes

isaakhanimann commented 3 weeks ago

I implemented this for the iOS app. Its the next thing that I will also implement for the Android app.