search

isaar / MSolve

Open source numerical solver for computational mechanics problems
Apache License 2.0
18 stars 26 forks source link

Move optimization benchmarks. #63

Closed mariatav closed 6 years ago

mariatav commented 6 years ago

@GoatOfRafin @SerafeimBakalakos

The benchmarks folder in Optimization project probably needs to be incorporated into the Tests project, along with the OptimizationTests project.

SerafeimBakalakos commented 6 years ago

Nope, they are not tests. They are meant to assess the performance of optimization algorithms, not the correctness or performance of the code itself. They could be used as unit/integration tests under circumstances, in which case they would probably need to interface with other modules (e.g. FEM). That code does belong in the OptimizationTests project. However, the description of the benchmarks should not have such dependencies (it currently does unfortunately) and it belongs in in the Optimization project.