dimtsap
commented
6 years ago A new Discretization project has been added to the solution that unifies teh interface between FEM and IGA projects so that the same providers, analyzer etc can be used. The new project contains the following :
Integration
- Moves the implementation of Serafeim to the common project as both discretizations use Gauss Quadrature.
- 1D/2D classes created by Serafeim are extended to 3D case by implementing the equivalent classes and interfaces
Interfaces
- Contains a set of minimum set of interfaces that each new discretization method must implement in order for it to be used with existing Solvers and Analyzers.
Providers
- All methods that contain an elemental structure should have the same ElementalMatrixProviders
Misc classes
- DOFTypes, GenerericDOFEnumerators and GlobalMatrixAssembler classes are unified between discretizaztion methods
Please comment on Discretization project so that any parts not addressed can be included or enhance the current implementation
During the porting of my code from Java to C# and MSolve specifically, I have noted that many parts of the Preprocessors apart from Elements are almost identical and thus can probably be refactored. These similar code parts can be split into the following categories:
Need abstraction
In this category belong the Entities folder of the two methods. The first reason why an abstraction is needed is that UQ/Optimization/Logging projects need to reference and alter the Model of each method. In the existing implementation, only FEM are supported while minimal changes are needed to extend the functionality. A comparison is given below:
Actually, isogeometric entities can be considered as an extension of the FEM ones in most cases. In a similar fashion Faces and Edge, where Loads and Boundary Condition are applied coexist as a concept in both cases but are applied in Elements in FEM while Patches in IGA.
Identical parts after the above refactoring
Provided that Nodes - Control Points, Elements and Subdomain-Patches can be handled in a similar fashion then the following parts of code become identical and thus much code rewriting can be spared. For example interfaces and simple classes can be unified:
Already refactored
In this category, we had identical code such as the Materials(2D-3D etc) which had no difference between the two methods.