search

isabelgk / IggyLabsModules

Modules for VCV Rack
GNU General Public License v3.0
11 stars 2 forks source link

Table incorrectly zero-pads wavetables of any import length option to be 2048 #14

Closed paulpiko closed 4 years ago

paulpiko commented 4 years ago

The table manual says WaveEdit creates 512 samples/cycle files. I used the default settings in WaveEdit to create a wavetable (all sines). Only when loaded at 2048 did it table produce a continuous wave.

table512 table2048
isabelgk commented 4 years ago

This is a mistake in the manual; WaveEdit creates table lengths of 256 samples. Can you try using the 256 import?

paulpiko commented 4 years ago

It's worse loading via 256, only one cycle

image

isabelgk commented 4 years ago

Hmmm can you share the sample with me?

isabelgk commented 4 years ago

Ah wait, I think I might know the issue. I'll have to wait until tomorrow to try it.

paulpiko commented 4 years ago

The wave file...

test.zip

isabelgk commented 4 years ago

If you can, could you try the latest build for your system with the fix implemented (see below)? Looks good with a bunch of tables I tested out.

IggyLabsModules-1.0.b95f16c-lin-20200710.zip IggyLabsModules-1.0.b95f16c-mac.zip IggyLabsModules-1.0.b95f16c-win.zip

paulpiko commented 4 years ago

I think you've fixed it! Looks good on first tests here. Thanks.

isabelgk commented 4 years ago

Great! Fix should be updated in the library very shortly.