isabelrem / 2023-Software-Development-Assessment

MIT License
2 stars 1 forks source link

Create function that calls panel data from API using R code as input #7

Closed isabelrem closed 9 months ago

isabelrem commented 10 months ago

Doesn't seem to be an endpoint for this in the documentation - however, we could use the test directory xml to convert between R code and Clinical Indication column.

isabelrem commented 10 months ago

Wrote code that downloaded national directory data from url, returned clinical indication when provided with an R code via user input, with some functionality to clean that user input e.g., removing dashes, adding 'R' if missing.

After writing discovered that it is possible to call gene panels from the API using the R code as input, using that in favour of the code described above as the API contains data that updates without us having to change our calling scripts, while my code will only be useful for as long as the current nhs test directory stays at the same url

isabelrem commented 10 months ago

Created function using Tom's call API data using disease description script as template. Submitted pull request for branch 7. Now going to write file where the R_code input is tested - does it begin with capital R? is the format correct? Between 2-3 digits? (3-4 including the R)

jess789550 commented 9 months ago

Done