search

isaced / appstore-connect-sdk

A TypeScript module for Node.js that interacts with the App Store Connect API, providing support for all APIs based on OpenAPI specification.
MIT License
27 stars 8 forks source link

Stay update with App Store Connect API latest version #12

Open dongsuo opened 1 year ago

dongsuo commented 1 year ago

Since App Store Connect API released 3.1 version now, will this repo upgrade to keep in pace with Connect API's version?

isaced commented 1 year ago

No updates planned at this time.

This project uses openapi-generator-cli to generate TypeScript code, but I found that it cannot generate code very well. There are many type errors and need to be modified manually again. Once the openapi spec json changes, it will be difficult to maintain.

I was wondering if there is a better way to maintain the repository. Like not using OpenAPI Generator, but there isn't a good answer yet.

isaced commented 1 year ago

Regarding the mentioned TypeScript type error problem, an example:

app_store_connect_api_2.2_openapi.json

...
      "SubscriptionStatusUrlVersion" : {
        "type" : "string",
        "enum" : [ "V1", "V2", "v1", "v2" ]
      },
...

Generated code:

export const SubscriptionStatusUrlVersion = {
    V1: 'V1',
    V2: 'V2',
    V1: 'v1',
    V2: 'v2'
} as const;

error: An object literal cannot have multiple properties with the same name.ts(1117)

There are many more like this, probably dozens of files with problems.