isacikgoz / tldr

fast and interactive tldr client written with go
https://isacikgoz.me/tldr/
MIT License
1.36k stars 48 forks source link

cli/prompt: fix race condition #26

Closed isacikgoz closed 3 years ago

isacikgoz commented 4 years ago

fixes #23 & #25

dolmen commented 4 years ago

Confirming. Looks fixed.

isacikgoz commented 4 years ago

In the tests, I observed that the prompt ignores first key input after selection, will dig into this.

codecov[bot] commented 3 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   42.01%   42.01%           
=======================================
  Files           2        2           
  Lines         119      119           
=======================================
  Hits           50       50           
  Misses         68       68           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3918253...64ba3d3. Read the comment docs.

isacikgoz commented 3 years ago

fixes #27