search

isacikgoz / tldr

fast and interactive tldr client written with go
https://isacikgoz.me/tldr/
MIT License
1.36k stars 48 forks source link

Some issues in v1.0.0-alpha #36

Open pvonmoradi opened 3 years ago

pvonmoradi commented 3 years ago

I've been using tldr++ version 0.6.1 for some time and it has been a great experience. Thank you very much for developing this!
There are a couple of issues in your latest release (tested on Xubuntu 18.04 in i3wm session) :
1- There is a considerable keyboard input latency (lag) when tldr is invoked (~ 1-2 seconds for each key press). For version 0.6.1 it was maybe ~500 ms. 2- For searching a command, you have to first use "/" which I find redundant. Since the user invokes tldr for searching a command, why make it harder by first pressing another key. 3- The number of default suggestions has been lowered to a couple of lines (personally I preferred the former 6 lines of suggestions).

A couple of feature requests 😉: 4- It would have been nice to be able to exit tldr with Esc key (currently only CTRL+C is possible).
5- When a command is completed in tldr, the command wouldn't get saved to bash history. I think this happens because you directly invoke the command in Go. Maybe you could instead exec the command directly on bash so it would be saved to history (or at least provide the option for doing so).

BTW, I think you should popularize your project more (over hackernews, reddit, etc). I think currently it is the only tldr client with fuzzy search + interactive completion of CLI tools switches.
Cheers :100:

isacikgoz commented 3 years ago

Hey @pvonmoradi thanks for the feedback! I really appreciate it 🚀

As for the issues: 1- Yes, when I get the chance I can review the search algorithm and explore possibilities to improve its performance. The performance is reduced because as you might noticed I changed the UI to my own library. But it need some fine tuning! 2- ~Actually I can add an option to start in search mode.~ My library supports it 👍 See https://github.com/isacikgoz/gitin 3- That is also supported. You can arrange your line size :) You need to export the environment variables:

  TLDR_LINESIZE=<int>
  TLDR_STARTINSEARCH=<bool>
  TLDR_DISABLECOLOR=<bool>

For the feature requests: 4- There was a reason that I picked CTRL-C but I don't remember it atm. I can think about this nonetheless. 5- Hmm, this is a very neat idea. I will look into this subject. I'd like to have the command is saved in the shell history as well.

I will need some help on spreading the word about this tool. But first things first I need to make this tool ready to be used by thousands w/o trouble :)