search

isacikgoz / tldr

fast and interactive tldr client written with go
https://isacikgoz.me/tldr/
MIT License
1.36k stars 48 forks source link

required newline in some shells #5

Closed JKomoroski closed 5 years ago

JKomoroski commented 5 years ago

Adds a new line to error output. Tested in bash and zsh on linux.

Screen shots of behavior before this commit in zsh: 2019-01-19-12-18-12_screenshot

2019-01-19-12-18-43_screenshot

Screenshots after this commit: 2019-01-19-12-19-46_screenshot

2019-01-19-12-20-22_screenshot

codecov[bot] commented 5 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   17.04%   17.04%           
=======================================
  Files           6        6           
  Lines         305      305           
=======================================
  Hits           52       52           
  Misses        252      252           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1719f8...67f783e. Read the comment docs.

isacikgoz commented 5 years ago

Thank you for the feedback and PR @JKomoroski

One of the errors was intentionally left without new line but others are OK. I commented on that. (ln:54 @ main.go).

Can you remove the new line from that? Then I will merge this branch 👍

JKomoroski commented 5 years ago

Removed. I wasn't able to trigger errors for all the cases so I just guessed on it.

isacikgoz commented 5 years ago

Thank you for your contribution @JKomoroski!