isacikgoz / tldr

fast and interactive tldr client written with go
https://isacikgoz.me/tldr/
MIT License
1.36k stars 48 forks source link

Doesn't work with yay #7

Closed AndersenJ closed 5 years ago

AndersenJ commented 5 years ago

I tried using tldr with yay, just to test it out, and got the following output:

 ~ $ tldr yay

yay

Yet Another Yogurt: A utility for Arch Linux to build and install packages from the Arch User Repository.
Also see `pacman`.

  Synchronize and update only AUR packages
   yay -Sua

? yay -Sua Yes
:: Searching AUR for updates...
 -> hsakmt-roct: local (1.8.3.r0.e3dd067-1) is newer than AUR (1.8.0.r0.e3dd067-2)
 -> Missing AUR Packages:  firefox-extension-shumway  gegl02  pcmciautils
 -> Out Of Date AUR Packages:   hsa-rocr  hsakmt-roct  mailpile
:: 2 Packages to upgrade.
2  aur/google-chrome  71.0.3578.98-1 -> 72.0.3626.81-1
1  aur/xnviewmp       0.92-1         -> 0.93-1
==> Packages to not upgrade: (eg: 1 2 3, 1-3, ^4 or repo name)
==> ^M^M 

In summary, my enter key was being eaten and converted to ^M rather than being registered by yay directly. Is this an issue with tldr++ or should I take it up with whoever maintains yay?

isacikgoz commented 5 years ago

Hello @AndersenJ thanks for the feedback. I think this is an issue with our source project tldr-pages I never used yay but the yay -Sua command does not seem to take an argument at all.

AndersenJ commented 5 years ago

It doesn't take any command-line arguments, but the command is interactive. I'll try to find time soon to look into whether I need to report this bug to tldr-pages; thanks.

Edit: Just to be clear, the problem is not that the wrong arguments are being selected or anything like that. It seems to be that the client is not passing stdin along properly to the child process. This is likely to also cause problems with other interactive commands too.

AndersenJ commented 5 years ago

I just realized that I was using an outdated binary. Sorry about the trouble. The problem doesn't seem to exist in the latest version from github.