search

isackrubio / gwt-cal

Automatically exported from code.google.com/p/gwt-cal
0 stars 0 forks source link

Bug using CalendarFormat, setTimeFormat has to re-generate hour labels #44

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
To be able to properly use the CalendarFormat class to overload the i18n
properties, is needed to apply the next fix to the setTimeFormat method

   public void setTimeFormat(String formatPattern) {
      timeFormat = DateTimeFormat.getFormat(formatPattern);
      generateHourLabels();
   }

Cheers.

Original issue reported on code.google.com by ctasada on 31 Mar 2010 at 9:45

GoogleCodeExporter commented 9 years ago 
The provided fix has been incorporated into the code base as of revision 299. I
really appreciate you providing the fix and your kind support.

Original comment by carlos.m...@gmail.com on 29 Apr 2010 at 3:43

GoogleCodeExporter commented 9 years ago 
Hi Carlos,

Please, double check the fix, since I still see

dateFormat = DateTimeFormat.getFormat(formatPattern);

and not

timeFormat = DateTimeFormat.getFormat(formatPattern);

as it should be.

Also I see that you've applied the fix only in trunk, shouldn't be included 
also in
the 0.91 branch?

Thanks.

Original comment by ctasada on 29 Apr 2010 at 7:39

GoogleCodeExporter commented 9 years ago

Original comment by Brad.Ryd...@gmail.com on 12 May 2010 at 7:05

GoogleCodeExporter commented 9 years ago 
Hi guys,

I see that this issue is marked as fixed, but it's not. I just double-checked 
the code both in trunk and branches. Please see my comments from Apr 29, 2010.

Cheers.

Original comment by ctasada on 7 Jul 2010 at 3:25