search

isadoranun / FATS

MIT License
75 stars 40 forks source link

compatibility with python 3 #7

Open linnabraham opened 7 years ago

linnabraham commented 7 years ago

I cannot import FATS on python3.4 produces syntax error

import FATS Traceback (most recent call last): File "", line 1, in File "/home/linn/.local/lib/python3.4/site-packages/FATS/init.py", line 2, in from .Feature import FeatureSpace File "/home/linn/.local/lib/python3.4/site-packages/FATS/Feature.py", line 93 print "Warning: the feature", name, "could not be calculated because", obj().Data, "are needed." ^ SyntaxError: invalid syntax

kiranvarmas commented 6 years ago

@ryanjmccall while we can import the FATS using python2 virtualenv, it may lead to backward compatibility issues , since arithmetic operators work differently in python3 when compared to python2. Is there any concrete solution other than creating a separate virtual env? Can't we use the from future import print_function and change the print statements to functions in the existing code?

stefanocovino commented 5 years ago

Dear friends,

if it helps, I'd support a real python3 version too!

Stefano

kiranvarmas commented 5 years ago

I made changes to make it compatible with python 3. However didn't test it with the test cases as I was busy working on my project. If you are willing, we can collaborate in creating a python 3 version.

stefanocovino commented 5 years ago

Gladly.

Please, let me know what you think it could be useful to test.

Bye, Stefano

Mobilis in mobile

Il giorno 12 mar 2019, alle ore 18:59, Sai Kiran Varma notifications@github.com ha scritto:

I made changes to make it compatible with python 3. However didn't test it with the test cases as I was busy working on my project. If you are willing, we can collaborate in creating a python 3 version.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

kiranvarmas commented 5 years ago

According to documentation, any changes made/introduced should pass the test cases specified . I have modified only part of the library to suffice my research. I can devote my time fully from May 1,2019.

Thanks, Kiran Varma

From: stefanocovino notifications@github.com Sent: 12 March 2019 3:00 PM To: isadoranun/FATS Cc: Sai Kiran Varma; Comment Subject: Re: [isadoranun/FATS] compatibility with python 3 (#7)

Gladly.

Please, let me know what you think it could be useful to test.

Bye, Stefano

Mobilis in mobile

Il giorno 12 mar 2019, alle ore 18:59, Sai Kiran Varma notifications@github.com ha scritto:

I made changes to make it compatible with python 3. However didn't test it with the test cases as I was busy working on my project. If you are willing, we can collaborate in creating a python 3 version.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/isadoranun/FATS/issues/7#issuecomment-472158639, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AjusQfKiA8fsb0iM2s4BNn_LSDAm4oGyks5vWAdtgaJpZM4PdbQ0.

OriginalGoku commented 1 year ago

Was this issue resolved?

stefanocovino commented 1 year ago

Actually, I don't even remember having raised it. It might well have been solved, but I haven't worked on this code since then.

Stefano