isadorasophia / murder

Murder is a pixel art ECS game engine.
https://isadorasophia.com/murder/
MIT License
2.45k stars 61 forks source link

NullReferenceException on asset variable on the TilemapRenderSystem when trying to reset the value #53

Closed slinaresperalta closed 10 months ago

slinaresperalta commented 10 months ago

Summary:

Editor crash when trying to reset the value of a tileset inside the TilesetComponent in world.

What should happen:

Editor shouldn't crash.

How to reproduce the issue:

https://github.com/isadorasophia/hellomurder/assets/94173512/96657bdd-0f29-467d-a5ec-2b1b005e3bcc https://github.com/isadorasophia/hellomurder/assets/94173512/e7509cf4-0426-4d21-ab39-884a75402c3b

saint11 commented 10 months ago

Thanks for reporting that! Fixed on https://github.com/isadorasophia/murder/commit/8fab4f2547e029e78d7d1fd9c62d039c0582002d Missed this because the "intended" way to edit tilesets is through here: 293521070-9ad68d6a-eeea-4a54-807f-566336bed658