search

isaiah / jubilee

A rack server built upon vert.x
http://isaiah.github.io/jubilee
MIT License
327 stars 18 forks source link

Interested in helping improving this project #31

Open Mahaswami opened 8 years ago

Mahaswami commented 8 years ago

I have just submitted a PR for jruby support and upgraded to latest vertx.

If you can share the known drawbacks or pointers to make this more compatible with rack changes etc, happy to fix them and share.

isaiah commented 7 years ago

The benefit of using vert.x as the rack web server, is to utilise the power of the EventBus, as it's easier to integrate with other "services" with the rails application. I didn't do much work on this project mainly because the performance with real world rails project is not that good, as Rails doesn't work well with asynchronous mode, to the best, it will be something like thin.

When I was actively working on this project, there is no good async database driver from vert.x (not sure if the situation has changed, last time I checked the async mysql plugin is not so good). If we want the goodness from both rails and vert.x, we have to provide the http client for asynchronous network operation and create an asynchronous activerecord-ish adapter (not sure if that's even possible?).

As a first step, I would improved the stability of the integration tests, so they don't fail randomly on travis.

Thanks for your interest.

Mahaswami commented 7 years ago

Thank you for responding Isaiah. Will revert with my comments more of my comments.

  1. Async DB Driver: They seem to have a decent Postgresql driver.
  2. Travis tests: Haven't done much with Travis. If you can share as couple of points as to where to begin, will attempt to improve on this aspect.