Wrong or missing arguments when calculating SMA

isaiahbjork / Auto-GPT-MetaTrader-Plugin

The AutoGPT MetaTrader Plugin is a software tool that enables traders to connect their MetaTrader 4 or 5 trading account to Auto-GPT.

https://github.com/isaiahbjork/Auto-GPT-MetaTrader-Plugin

MIT License

464 stars 82 forks source link

Wrong or missing arguments when calculating SMA #9

Open wmitnaj opened 1 year ago

wmitnaj commented 1 year ago

Hi,

I did some tests on a demo broker account and the sma command seems to either be wrong or is missing an argument because it always returns "Error: min_periods must be an integer". After that, AutoGPT tried the sma command with the min_periods argument, which resulted in another error "Error: AutoGPTMetaTraderPlugin.sma() got an unexpected keyword argument 'min_periods'.

After that, all the other indicators were calculated correctly but the system crashed due to the message finally being to long for openai to handle and I got the "message is too long" error. SMAError

isaiahbjork commented 1 year ago

Hi,

I did some tests on a demo broker account and the sma command seems to either be wrong or is missing an argument because it always returns "Error: min_periods must be an integer". After that, AutoGPT tried the sma command with the min_periods argument, which resulted in another error "Error: AutoGPTMetaTraderPlugin.sma() got an unexpected keyword argument 'min_periods'.

After that, all the other indicators were calculated correctly but the system crashed due to the message finally being to long for openai to handle and I got the "message is too long" error.

That's not a valid argument that's why, tell it to only use period. Sometimes it uses arguments that aren't allowed which is a bug and hopefully gets fixed in the future. I'll review it though and check the error on my end.

isaiahbjork commented 1 year ago

What command had a message that was too long? I tried to make sure that wouldn't happen with the data it pulls in.

wmitnaj commented 1 year ago

The initial goal was something like "Analyse the candlestick data of EURUSD and make smart trades to increase the net worth of the broker account". The command that crashed the system with a message that was too long was one of the other indicators after the sma. It had like 4317 characters and it said 4096 is the maximum. But I have to reproduce it to be sure which command it was.

isaiahbjork commented 1 year ago

The initial goal was something like "Analyse the candlestick data of EURUSD and make smart trades to increase the net worth of the broker account". The command that crashed the system with a message that was too long was one of the other indicators after the sma. It had like 4317 characters and it said 4096 is the maximum. But I have to reproduce it to be sure which command it was.

If you could reproduce the error that would be helpful so I can make sure it doesn't happen again

wmitnaj commented 1 year ago

It seems like at least the "message too long" error was simply my fault, because I didnt start autoGPT with --gpt3only. I fixed that and now the message problem seems to be fixed. But I still get the "Error: min_periods must be an integer" error everytime it tries to do the sma indicator, no matter how often I say it should only use period.

wmitnaj commented 1 year ago

In the meantime I did another test, it runs for about 10 Minutes now and basically loops through all the indicators but gets them wrong regularly as seen in the attached picture. When it finally tried to do a trade on the demo account, it got an error that trades are disabled, but I can trade via MT 4 fine. Maybe the api is disabled in the demo account? Errors

isaiahbjork commented 1 year ago

In the meantime I did another test, it runs for about 10 Minutes now and basically loops through all the indicators but gets them wrong regularly as seen in the attached picture. When it finally tried to do a trade on the demo account, it got an error that trades are disabled, but I can trade via MT 4 fine. Maybe the api is disabled in the demo account?

I've been using it on demo and its working fine and those indicators are working fine for me so that's weird. I will take a look again later tonight to see if I can reproduce your errors on my end and try to fix them.

toobongo999 commented 1 year ago

I also have the "Error: min_periods must be an integer" error, and then it tries to add it in and then gets the follow up error. I also added 'min_periods' into the init.py file in the metatrader zip folder, but this also didn't work, so took it out again. Interested to see if anyone comes up with a solution.