gitgraph.lua:987: assertion failed!

[kdheepak]

Thanks for making this plugin!

I wanted to report that I get the following error when I try to clone https://github.com/ratatui-org/ratatui and run gitgraph:

E5108: Error executing lua: .../.local/share/nvim/lazy/gitgraph.nvim/lua/gitgraph.lua:987: assertion failed!
stack traceback:
        [C]: in function 'assert'
        .../.local/share/nvim/lazy/gitgraph.nvim/lua/gitgraph.lua:987: in function 'commit_cell_symb'
        .../.local/share/nvim/lazy/gitgraph.nvim/lua/gitgraph.lua:1012: in function 'row_to_str'
        .../.local/share/nvim/lazy/gitgraph.nvim/lua/gitgraph.lua:1150: in function 'gitgraph'
        .../.local/share/nvim/lazy/gitgraph.nvim/lua/gitgraph.lua:1851: in function 'draw'
        /Users/USERNAME/.config/nvim/lua/kd/plugins/git-graph.lua:29: in function </Users/USERNAME/.config/nvim/lua/kd/plugins/git-graph.lua:28>
Press ENTER or type command to continue

[Xouzoura]

Same here for me in ubuntu

[isakbm]

Thank you.

Will try to reproduce this and get to the bottom of it.

[isakbm]

Was able to reproduce this, btw that repo looks amazing :) <3 Rust

[isakbm]

This is an interesting bug, it seems related to a branch called (origin/images), ... gitgraph tries to render this branch, but perhaps this branch has no common ancestors with the other branches 🤔

...

[isakbm]

Oh cool, I think I figured out what it is.

Commit 6754f92 has no parents, so has no ancestors in common with the rest of the repo. I just never considered handling this case. I'll probably have a fix in today. BTW git log --graph --oneline --dateorder shows this, but git log --graph --oneline show something quite confusing.

So at least gitgraph is failing rather than trying to show something confusing like git log --graph does :)

Will be great to have this fixed though! 🎉

Diving deeper now

[isakbm]

Should now be fixed, please git it a try 🤞

Thanks again for reporting this, this is what makes open source so great!

[kdheepak]

Yay! Thanks for the quick fix! Works perfectly for me now!