empv-play-thing-at-point fails when file name contains spaces

[pvagner]

Hello, I am a novice user so excuse me please if this might be me missing something. I have installed empv from melpa. I can't get empv-play-thing-at-point to play files that have spaces in their file names.

Steps

• Create an empty folder empv-issue in your home directory
• Put two MP3 files into it named file1.mp3 and file 2.mp3. Notice the second file has space in its file name.
• press c-x d empv-issue ret to open the dired buffer in this folder
• Use n and p to navigate
• When the point is on the line displaying the file name press m-x empv-play-thing-at-point

Results

The file where there are no spaces in its file names is playing fine but the other one with spaces is not playing.

Thanks for looking into it.

[isamert]

Thanks for opening an issue! I religiously use kebab-case in my filenames so did not notice this. Should be fixed for dired now. This also should mostly work on org-mode, eww etc. but it may fail on files with no proper way to detect filenames.

Tip: You can also select multiple files in dired and it still should work.