search

isamert / jaro

a highly customizable xdg-open alternative
GNU General Public License v3.0
67 stars 3 forks source link

change shebang invocation for guile to a more portable `env sh` #5

Closed zdm505 closed 3 years ago

zdm505 commented 3 years ago

UNIX systems can vary quite often where a binary might be with directory structures or the case of compiling something yourself. Example on my Fedora system /bin/guile doesn't even exist but /bin/guile2.2 does, but even further I'm using a newer Guile 3.0.5 which I've compiled myself that is located at /usr/local/bin/guile

Further tedium ensues with functional package management systems such as Guix or Nix, so I believe this to be the simplest and most portable approach, hopefully it helps.

For reference: https://www.gnu.org/software/guile/manual/html_node/Scripting-Examples.html

isamert commented 3 years ago

Thanks! That's a needed change. Any reason for using --no-auto-compile, I guess autocompile is a nice feature to have, in terms of gaining some speed. Considering that this program runs before everything.

zdm505 commented 3 years ago

Any reason for using --no-auto-compile, I guess autocompile is a nice feature to have, in terms of gaining some speed

That's a good point, the only reason for avoiding autocompliation would be that the first execution of jaro might be just a tad slower, that's about it. Thoughts?

isamert commented 3 years ago

Yeah, should not create any other problems. Also ~/.config/associations file is compiled automatically too (it's just another guile file). I don't have any benchmarks but it's supposed to be much faster. I'm using with auto-compile on from the beginning and haven't encountered any issues at all, it just happens without any problem.

isamert commented 3 years ago

Thanks!