search

isamert / scli

a simple terminal user interface for signal messenger (using signal-cli)
GNU General Public License v3.0
439 stars 40 forks source link

Don't crash when profile has no name key #121

Closed AckslD closed 3 years ago

AckslD commented 3 years ago

closes #120

exquo commented 3 years ago

Thanks! Yes, given that the name field might be absent, moving that dict lookup into the try/except clause is the right thing here.

I don't have any contacts that only have the uuid and not their phone numbers (that's what profiles[i]['name'] are) in their profiles. Just out of curiosity, is there anything special about those contacts?

Since there is no spec for what has to be in signal-cli's data file, I just go by what's in mine, and in some cases have to make assumptions about what "should" be expected to be there.

AckslD commented 3 years ago

@exquo Not completely sure actually, I'll try to find which contact that was and get back to you.

AckslD commented 3 years ago

Although, I'm not sure how to find that contact. I can see if in ~/.loca/share/signal-cli/data/<my-number> but not in signal-cli listContacts

exquo commented 3 years ago

Sorry, I should have mentioned that: you can search for that uuid in other places in the signal-cli data file (~/.loca/share/signal-cli/data/<my-number>). The uuid corresponding to a contact is a field in both the profileStore and contactStore. So by searching for it you can find which contact that entry in profileStore corresponds to.

By itself this of course will not tell you why that contact does not have a phone number in the profileStore like most (all?) of the rest normally do. But it might be a hint if you happen to know that the contact is "special" in some sense. Of course, there might not be anything apparently special about the contact; this might be caused by some signal configuration on your contact's side. In that case - oh well, it's just a bit of curiosity on my part anyway.

AckslD commented 3 years ago

No problem @exquo, thanks for the information!

So looking into this contact it seems to be someone who I haven't started a conversion with but we are both in the same group chat. I also don't have this contact in my contacts on my phone, not sure if that matters though.

exquo commented 3 years ago

That's a good clue, thanks!