crash when member names are ints

isamert / scli

a simple terminal user interface for signal messenger (using signal-cli)

GNU General Public License v3.0

439 stars 40 forks source link

crash when member names are ints #131

Closed mutax closed 3 years ago

mutax commented 3 years ago

I noticed a crash when the members are numeric, as the join later expects strings.

Quickfix:

@@ -3027,7 +3033,7 @@ class ChatWindow(urwid.Frame):
             if name != num:
                 markup.extend([' (', num, ')'])
         else:
-            memb_names = [memb.name_or_id for memb in contact.member_contacts]
+            memb_names = [str(memb.name_or_id) for memb in contact.member_contacts]

exquo commented 3 years ago

EDIT: removing my original comment, I have misunderstood the problem.

The issue is this: in version 2 of signal-cli's data file (introduced in v0.8.2) the v1 groups' members are stored as lists of IDs, instead of dicts with phone numbers as before.

Can reproduce, will work on a fix. Thanks!