search

isamert / scli

a simple terminal user interface for signal messenger (using signal-cli)
GNU General Public License v3.0
448 stars 39 forks source link

Handle signal-cli's new accounts.json #183

Closed mikeevmm closed 2 years ago

mikeevmm commented 2 years ago

This pull request seeks to solve https://github.com/isamert/scli/issues/182 .

I fudged the merges a little (I worked on master, then tried merging it to develop, then saw that develop was behind the upstream), sorry about that.

Also, please see the TODOs included; these are things I think the maintainer is in a better position to decide.

Finally, please test this PR with the old system, where the folder names match the numbers, to make sure I didn't break that; I don't have access to such a setup.

exquo commented 2 years ago

Thanks for the fix! I wrote one that is mostly the same as yours 70074a93c59eda1337b55fae0de0bd016a4bc0c2. If there are no issues, I can add it as another commit to this PR and merge the whole thing.

mikeevmm commented 2 years ago

Hi! Thanks, and yes; however I left a couple of comments for things that could help preserve backwards compatibility, I think.

exquo commented 2 years ago

Thanks for the comments! I've added replies on the commit page

mikeevmm commented 2 years ago

Sounds reasonable to me. Feel free to merge whenever you're ready to.