isamert / scli

a simple terminal user interface for signal messenger (using signal-cli)
GNU General Public License v3.0
432 stars 40 forks source link

Show "Contact's safety number has changed" as a message in conversation #213

Closed ghost closed 1 year ago

ghost commented 1 year ago

A contact i have has reinstalled signal (therefore getting a new security key) They sent me a message, but it didn't show up in scli

Only after i saw it on my phone and wrote a message, it synced with scli, though my message came first and the ones from my contact took a moment until they appeared and then appeared as the newest messages (aka wrong order)

Also with a new contact i had kinda the same issue

I got a notification of the message, but scli didn't even show the chat only after approving and sending a message from my phone, it showed up

taimon commented 1 year ago

This is most likely because signal-cli does not trust the new key. Check the signal-cli man page for the trust command or --trust-new-identities.

exquo commented 1 year ago

This is most likely because signal-cli does not trust the new key.

Yes, exactly.

Scli shows a notification at the bottom of the screen when a contact's safety number has changed (caused by reinstalling the app):

Could not decrypt a new message from '+<PHONE_NUM>'
Contact's safety number has changed: +<PHONE_NUM> (they might have reinstalled signal). Run `signal-cli trust …` to resolve.

What has probably happened is this notification was overwritten by some subsequent ones (e.g. another new message), perhaps too fast to be noticed.

To make such notifications less "missable", I'll look into adding a notification message to the conversation itself.

ghost commented 1 year ago

i (think i) figured out how to activate the --trust--new-identities=always ^^ actually wasn't that straight forward to me until i managed to find out that i can set my own command to start the signal-cli deamon

great work with the commit cheering really liked that from the android client, that it's just a hint in the conversation feed and really well done with the provided help on what command to use! (as i try not to have to use the cli directly and therefore don't really know the commands, it's nice to just now what needs to be done :) )