isamert / scli

a simple terminal user interface for signal messenger (using signal-cli)
GNU General Public License v3.0
432 stars 40 forks source link

Remote-deleted messages are not shown as deleted on a linked device #214

Closed exquo closed 1 year ago

exquo commented 1 year ago
          okay, I tested the message deleting and

a message written from my phone can be deleted on both devices via scli it only gets deleted on the phone when remote deleted via the phone

a message written from scli doesnt get deleted on my phone via scli remote delete also it cannot even be remote deleted from my phone (no option for that, only for self deletion)

Oh okay Sadly don't really understand the code, as i really like the UI :)

Originally posted by @meZeex in https://github.com/isamert/scli/issues/210#issuecomment-1445231515

exquo commented 1 year ago

Could not reproduce.. Tried for individual contacts and groups.

it only gets deleted on the phone when remote deleted via the phone

This is ambiguous, which of the two do you mean?

also it cannot even be remote deleted from my phone (no option for that, only for self deletion)

Could you be attempting this on the receiving device? Only the sender can "delete for everybody"

ghost commented 1 year ago

Could you be attempting this on the receiving device? Only the sender can "delete for everybody"

Both Devices use the same account

phone deletes message sent from phone => message stays on scli

scli deletes message sent from phone => deleted on both devices

phone deletes message sent from scli => isn't allowed to delete it

scli deletes message sent from scli => message stays on phone

For my understanding, it's the same account, so i should be able to delete the message from any device linked to that account

This was tested in the 'notes to self' chat

ghost commented 1 year ago

Okay, so i just realised that the 'note to self' chat has a different behaviour

When in a chat with another user, it works to get deleted from both devices, no matter where it was sent from

exquo commented 1 year ago

Thanks for the clarification! The "to-self" messages might indeed behave differently.

FWIW, with Signal Desktop, only the "Signal Desktop not allowed to delete a message sent from scli" case applies; the others seem to work as expected (i.e. the messages do get deleted). And even the case above might be the intended behavior by the signal devs.

Is there a usage scenario for remote-deleting messages to self, or were those just for testing?

ghost commented 1 year ago

i sometimes write notes to myself or send a text or link from device to device via the 'messages to self' chat, so it's nice when they can be deleted only once, but i guess it's okay knowing that it works that way

exquo commented 1 year ago

Ok, then we can probably close this. Since:

  1. This is an upstream question: essentially all scli is doing here is calling signal-cli remoteDelete.
  2. This might even be the intended behavior, as messages-to-self are treated specially.

Just a note (but might be relevant here): signal-cli has an additional flag --note-to-self to "send the message to self without notification".