search

isamert / scli

a simple terminal user interface for signal messenger (using signal-cli)
GNU General Public License v3.0
432 stars 40 forks source link

Fixed Pipe FDs closing after first line #222

Closed MareOfNights closed 4 months ago

MareOfNights commented 4 months ago

Urwid closes pipes, if the callback doesn't return True, so only the first line was read. This is the patch for that. Related Issue #221

exquo commented 4 months ago

Thanks for the fix! I've added one more return True there.

Since this is confirmed as a regression upstream, and the fix should be in the next release, we can eventually revert back these changes - once we're reasonably sure that none of our users are likely to have the affected versions of urwid. (Which might be tricky if v2.6.x gets frozen into any popular repos; for instance, 2.6.4 is at the moment in Debian unstable, the (future) Ubuntu 24.04 and some other distros)