search

isamert / scli

a simple terminal user interface for signal messenger (using signal-cli)
GNU General Public License v3.0
448 stars 39 forks source link

Misc improvments: style, efficiency #73

Closed exquo closed 4 years ago

exquo commented 4 years ago

This PR does not fix any bugs or introduce any new features, only improves the code quality in general.

isamert commented 4 years ago

Seems awesome!

isamert commented 4 years ago

Seems like 298758b causes auto-completion to use lowercase versions of the commands. This really disturbs the readability of the auto-complete list. I don't think command lookup really creates an overhead, even 100 command with multiple abbreviations will not take much time in the older implementation. I may simply revert this if can't find a better solution.

isamert commented 4 years ago

Following on earlier comment: I simply used the older data structure for completions, see 25f0d16.

exquo commented 4 years ago

Thanks!

Good call with the tab completion, it does look more readable with the capitalization.

I'm sure you're right about the performance - even on the slowest hardware the speed difference would probably not be noticeable. Still, I like the idea of conserving the CPU cycles :).