Device linking changes - Githubissues

exquo commented 3 years ago

I've opened this as a Pull Request to write the comments here.

BTW, there is a new "Discussions" function on github, but it needs to be enabled for the repo. Might be worthwhile to have discussions conveniently right here in GH without creating new issues or PRs.

Having device liking in scli itself is great!

Some changes I've made here:

I have a "light" colorscheme on my terminal, and the inverted-colors QR image that pyqrcode's terminal() produces by default, my phone refused to scan. I guess if you have a "dark" colorscheme, the resulting QR code looked normal with the default settings (black on white background). Also, added version=10 for the QR code, apparently might be required for 'newer' versions of android: https://github.com/AsamK/signal-cli/wiki/Linking-other-devices-(Provisioning)
Replaced Popen(cmd, shell=True) with Popen(cmd.split()), to remove the possibility of getting shell symbols in cmd.
Added / edited some printout messages. Added stderr printouts to error messages.

isamert commented 3 years ago

Well, looks great to me!

exquo commented 3 years ago

👍

On Fri-12:16, İsa Mert Gürbüz wrote:

Well, looks great to me!

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/isamert/scli/pull/96#issuecomment-751287404

This free account was provided by VFEmail.net - report spam to abuse@vfemail.net

ONLY AT VFEmail! - Use our Metadata Mitigator to keep your email out of the NSA's hands! $24.95 ONETIME Lifetime accounts with Privacy Features!
15GB disk! No bandwidth quotas! Commercial and Bulk Mail Options!

exquo commented 3 years ago

Thanks for creating the Discussions tab too!

On Fri-12:16, İsa Mert Gürbüz wrote:

Well, looks great to me!

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/isamert/scli/pull/96#issuecomment-751287404

This free account was provided by VFEmail.net - report spam to abuse@vfemail.net

ONLY AT VFEmail! - Use our Metadata Mitigator to keep your email out of the NSA's hands! $24.95 ONETIME Lifetime accounts with Privacy Features!
15GB disk! No bandwidth quotas! Commercial and Bulk Mail Options!

isamert / scli

Device linking changes #96