search

isamplesorg / isamples_inabox

Provides functionality intermediate to a collection and central
0 stars 1 forks source link

samplingSite location is "location", curation location is "curation_location" #308

Closed dannymandel closed 1 year ago

dannymandel commented 1 year ago

We are handling the "location" key inconsistently when it occurs inside subdictionaries in a document.

For example, in sampling_site:

        "samplingSite": {
            "description": "Depth to bottom 4.57 m",
            "label": "San Pedro Bay, breakwater",
            "location": {

https://github.com/isamplesorg/metadata/blob/264a71947b05cdb3a7ffad8303be43039a681ea6/examples/GEOME/test1.0Valid/ark-21547-DRW2LACM-DISCO-16924-v1.json#L88

but in curation:

    "curation": {
        "label": "",
        "description": "fixative: 95% ethanol; preservative: 95% ethanol; record modifiedBy: Mike O'Mahoney; modifiedReason: updated tissueID from 9013 to corrected value 9597 (19Aug20); sample identified: 2019-09-02; ",
        "access_constraints": [],
        "curation_location": "",

https://github.com/isamplesorg/metadata/blob/264a71947b05cdb3a7ffad8303be43039a681ea6/examples/GEOME/test1.0Valid/ark-21547-DRW2LACM-DISCO-16924-v1.json#L107C10-L107C27

Granted, one is a dictionary and one is a string, but it seems strange that the keys are different.

smrgeoinfo commented 1 year ago

lets make them consistent and make sampling_site/location to be sampling_site/sample_location

smrgeoinfo commented 1 year ago

fixed see https://github.com/isamplesorg/metadata/issues/160