search

isamplesorg / isamples_webui

Web interface to iSB and iSC APIs
https://isamplesorg.github.io/isamples_webui/
Apache License 2.0
0 stars 1 forks source link

Integrate vocabulary handlers #181

Closed dannymandel closed 7 months ago

dannymandel commented 7 months ago

This change hooks up the UI to the new vocabulary handlers on hyde. They are taking quite some time to respond, and I'm not sure why. I would appreciate @hyunssong advice on how to help make it faster.

If you happen to drill into the UI before the response comes back, React errors out. I am not sure why it is taking so long.

dannymandel commented 7 months ago

@hyunssong are the tests failing because of what you were talking about this morning at standup?

hyunssong commented 7 months ago

@dannymandel As the test cases are failing on the hierarchyFacet, I am assuming that is related to what I mentioned in today's standup. I opened a PR that has the updated test cases so that should be merged first I guess. FYI, The PR that has the updated test cases is #180.

dannymandel commented 7 months ago

@dannymandel As the test cases are failing on the hierarchyFacet, I am assuming that is related to what I mentioned in today's standup. I opened a PR that has the updated test cases so that should be merged first I guess. FYI, The PR that has the updated test cases is #180.

Yup, merged it in. Seems happy now. Thank you!

dannymandel commented 7 months ago

Docker changes to work with this in https://github.com/isamplesorg/isamples_docker/pull/64

dannymandel commented 7 months ago

Going to merge this one to get it tested out…