search

isamplesorg / metadata

Collation of metadata examples and notes for the project
https://isamplesorg.github.io/metadata/
8 stars 2 forks source link

Geome transformer #37

Closed dannymandel closed 2 years ago

dannymandel commented 2 years ago

Initial implementation of the GEOME transformer. It runs for the examples and produces mostly correct content. Going to put out the review and then try running it on MARS against all the records there.

Overall, used the notes in

https://github.com/isamplesorg/metadata/blob/main/examples/GEOME/GEOMEiSamplesMapping.json

plus the test examples to try and come up with the best possible initial implementation.

Note that this doesn't handle child records, those will come in a separate revision as they'll need some special handling.

dannymandel commented 2 years ago

@smrgeoinfo @qgan7125 @YuxuanZhou1 -- you all have spent more time looking at the GEOME examples than I have. If you have any suggestions on how to implement the fields where I've commented we need more info, please suggest away! Thank you.

qgan7125 commented 2 years ago

For the "@id", I notice the code concatenate "metadata:" prefix directly with the ark identifier but we remove "ark:" and use "metadata/21547/CgZ2PEER_7055". I am not sure which one is best. Hope it help.

dannymandel commented 2 years ago

I noticed the same thing about "@id", @qgan7125. Both it and sampleidentifier have some inconsistencies in the examples, so I wrote up: https://github.com/isamplesorg/metadata/issues/38

Thanks for the reminder!

dannymandel commented 2 years ago

Merging per discussion with @datadavev.