isamu / rocksdb-ruby

A simple RocksDB library for Ruby
MIT License
75 stars 24 forks source link

Build librocksdb 8.1.1 as part of the rocksdb-ruby gem #36

Closed johnny-lai closed 1 year ago

johnny-lai commented 1 year ago

Changes include:

Advantages of building librocksdb as part of the gem

Disadvantages:

johnny-lai commented 1 year ago

I don't see the Github Actions running against this PR. Perhaps it needs to be enabled on the repository? If you want an example of what it looks like, you can take a look at https://github.com/johnny-lai/rocksdb-ruby/pull/1 https://github.com/johnny-lai/rocksdb-ruby/actions/runs/5340814651

isamu commented 1 year ago

Thank you for very good suggestion.

I believe Github Acitons are done after pulling in the PR. If it is not executed, review the settings here.