isar-community / isar

Extremely fast, easy to use, and fully async NoSQL database for Flutter
https://isar-community.dev
Apache License 2.0
131 stars 15 forks source link

Tests fixes and small adjustments #34

Closed vicenterusso closed 5 months ago

vicenterusso commented 5 months ago

Do you have a use case where this will not work for end users?

mrclauss commented 5 months ago

Do you have a use case where this will not work for end users?

Uhm for everyone :) I'm pretty sure you cannot publish a package to pub.dev or our package repo that refers to local paths in its dependencies... This will only work if you have the isar sources checked out locally (which the regular user won't want)

vicenterusso commented 5 months ago

Do you have a use case where this will not work for end users?

Uhm for everyone :) I'm pretty sure you cannot publish a package to pub.dev or our package repo that refers to local paths in its dependencies... This will only work if you have the isar sources checked out locally (which the regular user won't want)

Should be an easy change after publishing then

richard457 commented 5 months ago

we might need to consider https://melos.invertase.dev/ for local packages this can help when it is time to publish as well to pub.dev

mrclauss commented 5 months ago

Looks good to me