Pinning macOS version - Githubissues

vicenterusso commented 4 months ago

The image macos-latest (macos-14) is now by default M1 and tests failed

mrclauss commented 4 months ago

Isn't there a way to pin the hardware to x64 instead of lowering the os version all the way down until where M1 was not supported?

vicenterusso commented 4 months ago

Isn't there a way to pin the hardware to x64 instead of lowering the os version all the way down until where M1 was not supported?

Yes, we can pin the platform to x64, but some tests failed on macos-13 too (x64), so they will probably fail on the latest (14) version

Interestingly, all tests from the v3 branch pass on latest (arm).

mrclauss commented 4 months ago

Hmm okay understood, but then I'd suggest we go one step back and try to understand why the tests fail. I didn't have a detailed look yet though. Did you already check what's wrong with those?

Am 1. Mai 2024 17:12:51 MESZ schrieb Vicente Russo @.***>:

Isn't there a way to pin the hardware to x64 instead of lowering the os version all the way down until where M1 was not supported?

Yes, we can pin the platform to x64, but some tests failed on macos-13 too (x64), so they will probably fail on the latest (14) version

Interestingly, all tests from the v3 branch pass on latest (arm).

-- Reply to this email directly or view it on GitHub: https://github.com/isar-community/isar/pull/66#issuecomment-2088611763 You are receiving this because your review was requested.

Message ID: @.***>

-- Martin Clauss Meine Contactulater Card - All meine Kontaktinfo immer aktuell und vollständig: https://contactulater.app/me/mc

vicenterusso commented 4 months ago

Hmm okay understood, but then I'd suggest we go one step back and try to understand why the tests fail. I didn't have a detailed look yet though. Did you already check what's wrong with those?

Doing that right now. Better fix, right?

frederikstonge commented 4 months ago

There seems to be an issue in packages/isar_test/lib/src/init_native.dart.

If you compare v3 and main:

v3

 Abi.macosArm64: path.join(
            rootDir,
            'target',
            'aarch64-apple-darwin',
            'release',
            binaryName,
          ),

main

Abi.macosArm64 => path.join(
        rootDir,
        'target',
        'debug',
        binaryName,
      ),

mrclauss commented 4 months ago

Good point, thank you!

Am 2. Mai 2024 13:37:47 MESZ schrieb Frederik St-Onge @.***>:

There seems to be an issue in packages/isar_test/lib/src/init_native.dart.

If you compare v3 and main:

v3
Abi.macosArm64: path.join(
           rootDir,
           'target',
           'aarch64-apple-darwin',
           'release',
           binaryName,
         ),
main
Abi.macosArm64 => path.join(
       rootDir,
       'target',
       'debug',
       binaryName,
     ),
-- Reply to this email directly or view it on GitHub: https://github.com/isar-community/isar/pull/66#issuecomment-2090283048 You are receiving this because your review was requested.

Message ID: @.***>

-- Martin Clauss Meine Contactulater Card - All meine Kontaktinfo immer aktuell und vollständig: https://contactulater.app/me/mc

vicenterusso commented 4 months ago

There seems to be an issue in packages/isar_test/lib/src/init_native.dart.

If you compare v3 and main:

v3

 Abi.macosArm64: path.join(
            rootDir,
            'target',
            'aarch64-apple-darwin',
            'release',
            binaryName,
          ),

main

Abi.macosArm64 => path.join(
        rootDir,
        'target',
        'debug',
        binaryName,
      ),

yep, found about that yesterday, testing with another repo. Also, integration test on linux is working. The only test failing is windows.. not sure what to do.. error message is not helpfull..

frederikstonge commented 4 months ago

There seems to be an issue in packages/isar_test/lib/src/init_native.dart. If you compare v3 and main: v3
 Abi.macosArm64: path.join(
            rootDir,
            'target',
            'aarch64-apple-darwin',
            'release',
            binaryName,
          ),
main
Abi.macosArm64 => path.join(
        rootDir,
        'target',
        'debug',
        binaryName,
      ),
yep, found about that yesterday, testing with another repo. Also, integration test on linux is working. The only test failing is windows.. not sure what to do.. error message is not helpfull..

Can you share the error message? Maybe I can help

vicenterusso commented 4 months ago

Can you share the error message? Maybe I can help

Sure there we go.. Maybe we could open a specific issue for this one?

Run flutter config --enable-windows-desktop
  flutter config --enable-windows-desktop
  flutter build windows -t lib/isar_test.dart
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    FLUTTER_ROOT: C:\hostedtoolcache\windows\flutter\stable-3.13.2-x64
    PUB_CACHE: C:\Users\runneradmin\AppData\Local\Pub\Cache
    CARGO_HOME: C:\Users\runneradmin/.cargo
    CARGO_INCREMENTAL: 0
    CARGO_TERM_COLOR: always
    PATH: C:\hostedtoolcache\windows\strawberry-perl\5.32.1\x64\perl\site\bin;C:\hostedtoolcache\windows\strawberry-perl\5.32.1\x64\perl\bin;C:\hostedtoolcache\windows\strawberry-perl\5.32.1\x64\c\bin;C:\Users\runneradmin\AppData\Local\Pub\Cache/bin;C:\hostedtoolcache\windows\flutter\stable-3.13.2-x64/bin/cache/dart-sdk/bin;C:\hostedtoolcache\windows\flutter\stable-3.13.2-x64/bin;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS\;C:\tools\zstd;C:\Program Files\Mercurial\;C:\hostedtoolcache\windows\stack\2.15.5\x64;C:\cabal\bin;C:\\ghcup\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.3.3\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver\;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.9\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.6\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.412-8\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\docker-compose;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\dotnet\;C:\Program Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform Installer\;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\;C:\Program Files\Microsoft SQL Server\150\Tools\Binn\;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files\Microsoft SQL Server\150\DTS\Binn\;C:\Program Files\Microsoft SQL Server\160\DTS\Binn\;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI\;c:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2\;C:\Program Files\Amazon\SessionManagerPlugin\bin\;C:\Program Files\Amazon\AWSSAMCLI\bin\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps
    PERL5LIB: D:\a\isar\isar\local\lib\perl5;D:\a\isar\isar\local\lib\perl5\MSWin32-x64-multi-thread;D:\a\_actions\shogo82148\actions-setup-perl\v1\scripts\lib
    LIBCLANG_PATH: C:\Program Files\LLVM\bin\
    OPENSSL_SRC_PERL: C:/Strawberry/perl/bin/perl
Setting "enable-windows-desktop" value to "true".

You may need to restart any open editors for them to read new settings.

windows/runner/Runner.rc does not use Flutter version information, updating.
Building Windows application...                                 
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for 'D:\a\isar\isar\packages\isar_test\build\windows\CMakeFiles\855b4729e9282b858941145c1cd258f6\flutter_windows.dll.rule;D:\a\isar\isar\packages\isar_test\build\windows\CMakeFiles\7a8a8244c7c6c88a2b71182262b68785\flutter_assemble.rule;D:\a\isar\isar\packages\isar_test\windows\flutter\CMakeLists.txt' exited with code 1. [D:\a\isar\isar\packages\isar_test\build\windows\flutter\flutter_assemble.vcxproj]
Building Windows application...                                    18.3s
Build process failed.
Error: Process completed with exit code 1.

frederikstonge commented 4 months ago

error MSB8066

https://stackoverflow.com/questions/67031371/flutter-windows-cannot-build-app-error-msb8066

Also, we could add -v to this line :

 flutter build windows -v -t lib/isar_test.dart

I also notice the version of flutter is quite old.

vicenterusso commented 4 months ago

I also notice the version of flutter is quite old.

Yeah, we should keep a good range for compatibility

flutter build windows -v -t lib/isar_test.dart

Let me try a verbose mode

Lets continue here: https://github.com/isar-community/isar/issues/68

vicenterusso commented 4 months ago

Closing because pinning is not a real solution. Fix is already done for mac. Will create a PR later

isar-community / isar

Pinning macOS version #66