Open psengrith opened 2 months ago
@vicenterusso Do you have an idea why the github action workflow did not build this pull request?
@vicenterusso Do you have an idea why the github action workflow did not build this pull request?
No clue, maybe because it was marked as a draft? just guessing..
This pull request updates the following files in the mdbx_sys package:
README.md
which explains steps to properly build the package on Windows for Rust Development.build.rs
to fix build errors on Windows: Specifically, the new script introduces workarounds to solve:bindgen
incompatibility withclang
(#2500), and-D MDBX_LOCK_SUFFIX
was properly configured for Windows build through CMake. This could potentially result in undefined behavior in Windows since the isar logic (e.g.,IsarInstance::close_internal
) is hard-coded to depend on the suffix.lock
.Note: This an updated pull request of the amended #87 (because directory structure mistake)