search

isar / hive

Lightweight and blazing fast key-value database written in pure Dart.
Apache License 2.0
4.11k stars 409 forks source link

Added `deleteAllAt()` to remove list of indices #1227

Closed Alexandre2006 closed 7 months ago

Alexandre2006 commented 1 year ago

As suggested in this StackOverflow thread, I've added a function that allows multiple elements in a box to be deleted at the same time based off of a list of indices.

I've also written tests for the new function.

Alexandre2006 commented 1 year ago

Any updates on merging this PR?

themisir commented 1 year ago

Sorry for this one taking so long, I am not sure about merging the change as it doesn't add any new feature to the library. There's already existing methods for converting indices to keys and method for deleting items in bulk with keys. This is by no means a final decision, just my personal opinion. Maybe other maintainers may have different opinions.

Alexandre2006 commented 1 year ago

Understood. I think this just improves developer experience in some cases.