isard-vdi / isard

Isard VDI. Open Source KVM Virtual Desktops based on KVM Linux and dockers. Please use https://gitlab.com/isard/isardvdi
http://www.isardvdi.com
GNU Affero General Public License v3.0
188 stars 57 forks source link

Possible log injection opportunity in code #443

Open openrefactory opened 1 year ago

openrefactory commented 1 year ago

In file: api_admin_socketio.py, there is a method that stores user-provided data into logs without validating the data. This allows an attacker to corrupt the log file structure (https://cwe.mitre.org/data/definitions/117.html).

User-provided data should be sanitized before it can be added to logs. It is unclear how the log data is used, or which part of the user input need to be logged. Therefore, no fix was suggested.