search

isard-vdi / isard

Isard VDI. Open Source KVM Virtual Desktops based on KVM Linux and dockers. Please use https://gitlab.com/isard/isardvdi
http://www.isardvdi.com
GNU Affero General Public License v3.0
188 stars 57 forks source link

Media - Upload from URL only HTTPS allowed ? #451

Closed markomdinic closed 1 month ago

markomdinic commented 3 months ago

Why on earth would you hardcode https enforcement for media upload URLs, especially when that https also requires a valid cert ? I don't know it that has always been the case, but now definitely is. If one wants to upload an ISO or a virtual disk image from a home machine, they need to have a web server fully set up for https, along with a valid certificate, which also implies a valid domain. Not every enthusiast out there is able or willing to go to such lenghts just to check out the project.

Shouldn't enforcement of such limiting factor be left for administrators to decide ?

sim6 commented 3 months ago

This policy was introduced recently via v11.29.22. In a future we will replace this ISO download feature with one that allows to upload an ISO through the web browser. But if you want a configuration option to bypass this policy, please request it via https://gitlab.com/isard/isardvdi/-/issues/new.

sim6 commented 2 months ago

@markomdinic can we close this issue?

acarfer940 commented 1 month ago

@markomdinic can we close this issue?

FYI: I've created an specific feature to allow HTTP connections in the media import form.

https://gitlab.com/isard/isardvdi/-/issues/675

I'm not an expert in IsardVDI because I've started to use it few months ago, but if it's useful, maybe I can take care of this and make a first PR to check by the main developers of the solution.

markomdinic commented 1 month ago

@markomdinic can we close this issue?

Sorry for late reply ... I really have to reduce the number of email accounts i need to shuffle ....

Anyway, yes, thank you, you can close it.

sim6 commented 1 month ago

Thanks